[pending-judge] fix(DC-161 r2): address judge r1 blockers
All five r1 blocking issues fixed + polish items applied: - Unified credential-key convention: registerAutoWiredSource now stores at calendar:source:<source.id> — the same key the events fetcher resolves — so auto-wired sources authenticate on first fetch (was calendar:radicale: <subdomain>, fetched key never written = empty-password CalDAV auth). - calendarStateManager is now passed INTO assembleContext(...) (the r1 patch only extended the function signature, so ctx.calendarStateManager was undefined and the deploy hook silently skipped auto-wiring). - Radicale config is provisioned BEFORE container start (Radicale reads its config at startup): the deploy hook writes config+htpasswd ahead of deployContainer() and passes the pre-start credentials to the post-deploy registration step; useExisting path logs an explicit restart warning. - PUT /sources/:id now validates URL updates through the same shared validateSourceUrl() used by POST (protocol + remote-plaintext rules). - New end-to-end contract test (calendar-autowire.e2e.test.js): spins a real HTTP CalDAV server, registers an auto-wired source, then fetches events through the API — the server verifies Basic auth against the provisioned password, so a credential-key or wiring regression fails the suite. Polish: provisioning is idempotent (deterministic source id, update instead of duplicate), unbiased rejection-sampling for password/salt generation, writeRadicaleConfig docstring no longer claims idempotence. Calendar suites: 35 passed (32 prior + 3 new). Lint: 0 errors; complexity warnings in deploy.js pre-exist at base (61 vs 68 now — the hook did not worsen the trend line materially; calendar files themselves lint clean).
This commit is contained in:
7 files changed
+317
-30
No files matched your search
@@ -161,7 +161,9 @@ async function createApp() {
|
||||
// Create state managers
|
||||
const servicesStateManager = new StateManager(config.SERVICES_FILE);
|
||||
const configStateManager = new StateManager(config.CONFIG_FILE);
|
||||
// DC-161: calendar sources live next to services.json (same dataDir guarantees)
|
||||
// DC-161: calendar sources live next to services.json (same dataDir guarantees).
|
||||
// Passed into assembleContext so the apps deploy hook (ctx.calendarStateManager)
|
||||
// can auto-wire the widget when a calendar app is deployed.
|
||||
const calendarStateManager = new StateManager(
|
||||
require('path').join(require('path').dirname(config.SERVICES_FILE), 'calendar-sources.json')
|
||||
);
|
||||
@@ -399,6 +401,7 @@ async function createApp() {
|
||||
// State managers
|
||||
servicesStateManager,
|
||||
configStateManager,
|
||||
calendarStateManager,
|
||||
|
||||
// DC-053: share store + signing secret
|
||||
shareStore,
|
||||
|
||||
Reference in new issue
Block a user