fix(routes): complete post-refactor dependency wiring cleanup

dashcaddy-api/routes/recipes/deploy.js

@@ -14,9 +14,9 @@ const { DOCKER } = require('../../constants');
  * @param {Object} deps.log - Logger instance
  * @returns {express.Router}
  */
-module.exports = function(ctx) {
-  const { docker, credentialManager, servicesStateManager, asyncHandler, errorResponse, log } = ctx;
+module.exports = function({ docker, credentialManager: _credentialManager, servicesStateManager: _servicesStateManager, asyncHandler, errorResponse: _errorResponse, log, addServiceToConfig, notification, APP_TEMPLATES, siteConfig, caddy, buildDomain }) {
   const router = express.Router();
+  const ctx = { addServiceToConfig, notification, APP_TEMPLATES, siteConfig, caddy, buildDomain };
 
   /**
    * Deploy a recipe — creates multiple containers as a coordinated stack
@@ -24,6 +24,7 @@ module.exports = function(ctx) {
    * POST /api/recipes/deploy
    * Body: { recipeId, config: { selectedComponents, sharedConfig, componentOverrides } }
    */
+  // eslint-disable-next-line complexity
   router.post('/deploy', asyncHandler(async (req, res) => {
     const { recipeId, config } = req.body;
     const { RECIPE_TEMPLATES } = require('../../recipe-templates');
@@ -44,7 +45,6 @@ module.exports = function(ctx) {
 
     // Generate shared passwords for the recipe (consistent across components)
     const generatedPasswords = {};
-    const passwordKey = `recipe-${recipeId}-${Date.now()}`;
     generatedPasswords.default = crypto.randomBytes(24).toString('base64url');
 
     // Create Docker network if defined
@@ -185,6 +185,7 @@ module.exports = function(ctx) {
   /**
    * Deploy a single component of a recipe
    */
+  // eslint-disable-next-line complexity
   async function deployComponent(component, recipe, config, passwords, networkName) {
     const sharedConfig = config.sharedConfig || {};
     const overrides = config.componentOverrides?.[component.id] || {};
@@ -364,7 +365,7 @@ module.exports = function(ctx) {
   /**
    * Run auto-connect steps after recipe deployment
    */
-  async function runAutoConnect(recipe, deployedComponents, config) {
+  async function runAutoConnect(recipe, _deployedComponents, _config) {
     if (!recipe.autoConnect?.steps) return;
 
     // Wait for services to be fully ready

dashcaddy-api/routes/recipes/index.js

@@ -17,7 +17,13 @@ module.exports = function(ctx) {
     servicesStateManager: ctx.servicesStateManager,
     asyncHandler: ctx.asyncHandler,
     errorResponse: ctx.errorResponse,
-    log: ctx.log
+    log: ctx.log,
+    notification: ctx.notification,
+    buildDomain: ctx.buildDomain,
+    caddy: ctx.caddy,
+    addServiceToConfig: ctx.addServiceToConfig,
+    APP_TEMPLATES: ctx.APP_TEMPLATES,
+    siteConfig: ctx.siteConfig
   };
 
   // All recipe routes require premium license

dashcaddy-api/routes/recipes/manage.js

@@ -2,9 +2,12 @@ const express = require('express');
 const { DOCKER } = require('../../constants');
 const { NotFoundError } = require('../../errors');
 
-module.exports = function(ctx) {
-  const { servicesStateManager, asyncHandler, log } = ctx;
+module.exports = function({ servicesStateManager, asyncHandler, log, docker, notification, buildDomain, caddy }) {
   const router = express.Router();
+
+  // Ctx shim for backward compatibility
+  const ctx = { docker, notification, buildDomain, caddy };
+
 /**
  * Recipes management routes factory
  * @param {Object} deps - Explicit dependencies
@@ -303,7 +306,7 @@ module.exports = function(ctx) {
    */
   async function removeCaddyBlock(subdomain) {
     const domain = ctx.buildDomain(subdomain);
-    let content = await ctx.caddy.read();
+    const content = await ctx.caddy.read();
 
     // Find and remove the block for this domain
     const escapedDomain = domain.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');