sami7777/dashcaddy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: harden deploy error handling - guard against undefined errors, safeErrorMessage null check
CI / Test & Lint (push) Has been cancelled
Details
CI / Security audit (push) Has been cancelled
Details

Browse Source 
- deploy.js: wrap logError/notification in try/catch so they never mask the original deploy error
- deploy.js: use optional chaining for error.message access
- logging.js: safeErrorMessage handles null/undefined error gracefully
This commit is contained in:
Hermes
2026-06-10 16:39:14 -07:00
parent f4b35dcc30
commit 0e408974a0
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dashcaddy-api/routes/apps/deploy.js
+4 -3
View File
@@ -420,10 +420,11 @@ module.exports = function({ docker, caddy, credentialManager, servicesStateManag
res.json(response); res.json(response);
} catch (error) { } catch (error) {
await logError('app-deploy', error, { appId, config }); try { await logError('app-deploy', error, { appId, config }); } catch (_) { /* logError failure should not mask original error */ }
log.error('deploy', 'Deployment failed', { appId, error: error.message }); const msg = error?.message || String(error || 'Unknown error');
log.error('deploy', 'Deployment failed', { appId, error: msg });
const template = ctx.APP_TEMPLATES[appId]; const template = ctx.APP_TEMPLATES[appId];
ctx.notification.send('deploymentFailed', 'Deployment Failed', `Failed to deploy **${template?.name || appId}**.\nError: ${error.message}`, 'error'); try { ctx.notification.send('deploymentFailed', 'Deployment Failed', `Failed to deploy **${template?.name || appId}**.\nError: ${msg}`, 'error'); } catch (_) {}
errorResponse(res, 500, ctx.safeErrorMessage(error)); errorResponse(res, 500, ctx.safeErrorMessage(error));
} }
}, 'apps-deploy')); }, 'apps-deploy'));
dashcaddy-api/src/utils/logging.js
+1
View File
@@ -94,6 +94,7 @@ async function logError(ERROR_LOG_FILE, MAX_ERROR_LOG_SIZE, context, error, addi
* Return a safe error message without leaking internals * Return a safe error message without leaking internals
*/ */
function safeErrorMessage(error) { function safeErrorMessage(error) {
if (!error) return 'An internal error occurred';
const msg = error.message || String(error); const msg = error.message || String(error);
// Detect port conflict errors // Detect port conflict errors