DC-004: mark done (zero ESLint warnings)

2026-06-25 06:22:19 -07:00
parent a37e79a8fc
commit 1da341b1c5
1 changed files with 2 additions and 1 deletions
@@ -38,9 +38,10 @@
 ## P1 — Code Quality
 ### DC-004: Fix 19 ESLint warnings
- **status:** in-progress
+- **status:** done
 - **owner:** hermes
 - **details:** Run `cd dashcaddy-api && npx eslint src/ --format compact`. Most are unused vars and nested ternaries in `src/utils/logging.js`. Fix all, target zero warnings.
 - **result:** Reached zero ESLint warnings across `src/`. Most of the original 19 were cleared by the DC-005 refactor and logging cleanup; the final 3 were in `src/app.js`: (1) `require-await` on `resyncHealthChecker` — dropped the now-pointless `async` keyword since it only forwards a promise (callers already use `.catch()`); (2)+(3) two `max-depth` violations in the `/api/v1/network/ips` handler — extracted the interface-enumeration logic into a `detectInterfaceIps()` helper, keeping the route handler flat. `npx eslint src/` now reports 0 problems; 750/750 Jest tests still pass.
 ### DC-005: Organize top-level modules into src/
 - **status:** in-progress