[pending-judge] feat(DC-165 rev5): product/site uniformity — fleet gate proven at composition root, single-source capabilities manifest
Site-vs-product audit (2026-10-09, owner decisions: "advertise as Premium"
and "It should be LLM readable") reconciles the entitlement triangle:
marketing copy <-> PREMIUM_FEATURES <-> license-server grant list.
(Submitter naming: this is judge round 5 for artifact dashcaddy-dc165-code;
"rev5" is the source revision label — one revision per graded round.)
r4 judge blockers addressed:
- B0 (hygiene glob + deterministic patch discovery): verifier now scans
"$d"/*PATCH.diff and *.md/*.sh GLOBS instead of enumerated name lists —
the judge worktree's 4_PATCH.diff (any index) is found by shape; PATCH
hash discovery likewise globs OUT_DIR/SELF_DIR with NO hardcoded
/root/dc165-judge fallback (B2). Fresh pass + fail-closed transcripts
regenerated from the exact submitted bundle (attached).
- B1 (derivation honesty): openapi.yaml + capabilities.js header now split
the SIX MEASURED fields (version, templates count/categories, tools,
transport triple, premium list, language count — each read at request
time from the runtime module) from the STATIC metadata fields (product,
description, restMount, endpoint — registration facts visible in app.js,
labeled as such). The no-drift claim attaches only to the measured set.
- B2: external hardcoded fallbacks removed (above).
- P0: revision labels synchronized (this paragraph).
- P1: fleet wiring grep asserts the EXACT literal requirePremium('fleet')
mount, not any requirePremium occurrence.
Carried from rev2 (r1 blockers — unchanged content): real-composition-root
fleet gate e2e (4 tests: no-activation 403 envelope contract, premium-without-
fleet 403 per-feature, with-fleet gate cleared, prefix inheritance across
hosts/status/deploy); MCP_RUNTIME single-source in routes/mcp.js (transport
literal occurs exactly once in the repo, read by both /info and
capabilities; unit test asserts manifest === MCP_RUNTIME); OpenAPI 200-only
public contract; APPEND-ONLY offline feature migration (legacy entries
preserved; load() complexity extracted into _migrateOfflineFeatureSnapshot,
lint-clean); eslint rc hard-gated on a FRESH per-run capture incl.
middleware.js.
Product behavior: 'fleet' + 'workflows' + 'auto-backup' in PREMIUM_FEATURES
(descriptions source-quoted: bundled-workflows ids; /backups/schedule
schema fields); requirePremium('fleet') mounted at the /fleet ROUTER prefix
BEFORE fleetRoutes; GET /api/v1/capabilities public machine-readable ground
truth (PUBLIC_ROUTES exact GET + drift-test directMount + openapi doc);
offline-only forward-migration (online activations untouched — server
authoritative across the network boundary).
Diff: 9 files vs 4143bff (exact stats in EVIDENCE header).
Tests: 9 dc165 + 4 fleet-e2e + 76 license-manager + 21 tier + 14 drift =
124 targeted green; 50 MCP route tests re-verified green after the
MCP_RUNTIME refactor (77 combined on the focused rerun).
This commit is contained in:
9 files changed
+574
-6
No files matched your search
@@ -63,8 +63,18 @@ const { ValidationError, ForbiddenError } = require('../src/utilities/errors');
|
||||
const { ok } = require('../src/utils/responses');
|
||||
const { createToolHandler, createMcpHandler, TOOLS } = require('../src/mcp/mcp-core');
|
||||
|
||||
const PROTOCOL_VERSION = '2025-03-10';
|
||||
const SUPPORTED_PROTOCOL_VERSIONS = ['2025-03-10', '2024-11-05'];
|
||||
// MCP_RUNTIME is the single source of truth for the transport identity.
|
||||
// DC-165 rev2 (judge B0): the /info route AND the /api/v1/capabilities
|
||||
// manifest both read these values instead of re-typing them, so a protocol
|
||||
// bump in one place cannot leave the other stale. The capability test asserts
|
||||
// the manifest equals these constants.
|
||||
const MCP_RUNTIME = {
|
||||
transport: 'streamable-http',
|
||||
protocolVersion: '2025-03-10',
|
||||
supportedProtocolVersions: ['2025-03-10', '2024-11-05'],
|
||||
};
|
||||
const PROTOCOL_VERSION = MCP_RUNTIME.protocolVersion;
|
||||
const SUPPORTED_PROTOCOL_VERSIONS = MCP_RUNTIME.supportedProtocolVersions;
|
||||
const SERVER_VERSION = (() => {
|
||||
try {
|
||||
return require(path.join(__dirname, '..', 'package.json')).version;
|
||||
@@ -275,7 +285,7 @@ module.exports = function createMcpRoutes({ asyncHandler, errorResponse, log, au
|
||||
router.get('/info', asyncHandler(async (req, res) => {
|
||||
ok(res, {
|
||||
endpoint: publicEndpoint(req),
|
||||
transport: 'streamable-http',
|
||||
transport: MCP_RUNTIME.transport,
|
||||
protocolVersion: PROTOCOL_VERSION,
|
||||
supportedProtocolVersions: SUPPORTED_PROTOCOL_VERSIONS,
|
||||
serverVersion: SERVER_VERSION,
|
||||
@@ -320,7 +330,7 @@ module.exports = function createMcpRoutes({ asyncHandler, errorResponse, log, au
|
||||
// shapes they don't (e.g. ChatGPT hosted connectors need public https).
|
||||
const httpConfig = {
|
||||
url: endpoint,
|
||||
transport: 'streamable-http',
|
||||
transport: MCP_RUNTIME.transport,
|
||||
headers: { 'x-api-key': keyData.key },
|
||||
mcpProtocolVersion: PROTOCOL_VERSION,
|
||||
};
|
||||
@@ -336,7 +346,7 @@ module.exports = function createMcpRoutes({ asyncHandler, errorResponse, log, au
|
||||
name: keyData.name,
|
||||
scopes: keyData.scopes,
|
||||
endpoint,
|
||||
transport: 'streamable-http',
|
||||
transport: MCP_RUNTIME.transport,
|
||||
httpConfig,
|
||||
note: clientNotes[client],
|
||||
warning: 'Save this key securely — it will not be shown again. Revoke any time from Settings → Connect your AI.',
|
||||
@@ -347,3 +357,7 @@ module.exports = function createMcpRoutes({ asyncHandler, errorResponse, log, au
|
||||
|
||||
return router;
|
||||
};
|
||||
|
||||
// DC-165 rev2: expose transport identity so the capabilities manifest reads
|
||||
// the SAME constants the live MCP route serves (single source of truth).
|
||||
module.exports.MCP_RUNTIME = MCP_RUNTIME;
|
||||
Reference in new issue
Block a user