From 4c2e4ed9862eb9d9e2026a5a493f823d2741c71b Mon Sep 17 00:00:00 2001 From: Sami Date: Mon, 30 Mar 2026 03:23:59 -0700 Subject: [PATCH] fix: resolve ctx naming conflict in arr/config.js, add pylon to known config keys - Remove redundant ctx shim that conflicted with function parameter - Use destructured notification/safeErrorMessage directly - Add pylon, customLogoDark, customLogoLight to known config keys Co-Authored-By: Claude Opus 4.6 --- dashcaddy-api/config-schema.js | 3 ++- dashcaddy-api/routes/arr/config.js | 9 ++------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/dashcaddy-api/config-schema.js b/dashcaddy-api/config-schema.js index 9cf0948..c8b5438 100644 --- a/dashcaddy-api/config-schema.js +++ b/dashcaddy-api/config-schema.js @@ -117,7 +117,8 @@ function validateConfig(config) { 'setupComplete', 'setupCompleted', 'setupMode', 'onboardingCompleted', 'configurationType', 'defaults', 'customLogo', 'customFavicon', 'dashboardTitle', 'tailscale', 'license', 'skipped', - 'routingMode', 'domain', 'email', 'defaultIP' + 'routingMode', 'domain', 'email', 'defaultIP', 'pylon', + 'customLogoDark', 'customLogoLight' ]; for (const key of Object.keys(config)) { if (!knownKeys.includes(key)) { diff --git a/dashcaddy-api/routes/arr/config.js b/dashcaddy-api/routes/arr/config.js index ed4afb0..be37c95 100644 --- a/dashcaddy-api/routes/arr/config.js +++ b/dashcaddy-api/routes/arr/config.js @@ -21,11 +21,6 @@ module.exports = function(ctx) { const { credentialManager, servicesStateManager, docker, fetchT, asyncHandler, errorResponse, log, helpers, notification, safeErrorMessage } = ctx; const router = express.Router(); - // Ctx shim for backward compatibility - const ctx = { - notification, - safeErrorMessage - }; // Auto-configure Overseerr with detected services router.post('/arr/configure-overseerr', asyncHandler(async (req, res) => { @@ -282,7 +277,7 @@ module.exports = function(ctx) { } else if (error.name === 'AbortError' || error.message?.includes('timeout')) { return errorResponse(res, 504, 'Connection timeout'); } - return errorResponse(res, 500, ctx.safeErrorMessage(error)); + return errorResponse(res, 500, safeErrorMessage(error)); } }, 'arr-test-connection')); @@ -484,7 +479,7 @@ module.exports = function(ctx) { // Send notification if (anyConfigured) { - ctx.notification.send( + notification.send( 'deploymentSuccess', 'Arr Stack Auto-Connected', `Overseerr configured: ${Object.entries(configResults).filter(([k,v]) => v === 'configured').map(([k]) => k).join(', ')}`,