refactor(routes): Phase 3.6-10 - standardize 5 utility routes

- credentials.js (2 deps: credentialManager, asyncHandler)
- backups.js (2 deps: backupManager, asyncHandler)
- license.js (2 deps: licenseManager, asyncHandler)
- errorlogs.js (3 deps: ERROR_LOG_FILE, auditLogger, asyncHandler)
- themes.js (0 deps! Standalone route)

Total: 9 routes refactored so far

dashcaddy-api/routes/license.js

@@ -1,53 +1,59 @@
 const express = require('express');
+const { success, error: errorResponse } = require('../response-helpers');
 
-module.exports = function(ctx) {
+/**
+ * License routes factory
+ * @param {Object} deps - Explicit dependencies
+ * @param {Object} deps.licenseManager - License management module
+ * @param {Function} deps.asyncHandler - Async route handler wrapper
+ * @returns {express.Router}
+ */
+module.exports = function({ licenseManager, asyncHandler }) {
   const router = express.Router();
 
   // Activate a license code
-  router.post('/activate', ctx.asyncHandler(async (req, res) => {
+  router.post('/activate', asyncHandler(async (req, res) => {
     const { code } = req.body;
     if (!code) {
-      return ctx.errorResponse(res, 400, 'License code is required');
+      return errorResponse(res, 'License code is required', 400);
     }
 
-    const result = await ctx.licenseManager.activate(code);
+    const result = await licenseManager.activate(code);
 
     if (result.success) {
-      res.json({
-        success: true,
+      success(res, {
         message: result.message,
         license: result.activation
       });
     } else {
-      ctx.errorResponse(res, 400, result.message);
+      errorResponse(res, result.message, 400);
     }
   }, 'license-activate'));
 
   // Get current license status
-  router.get('/status', ctx.asyncHandler(async (req, res) => {
-    const status = ctx.licenseManager.getStatus();
-    res.json({ success: true, license: status });
+  router.get('/status', asyncHandler(async (req, res) => {
+    const status = licenseManager.getStatus();
+    success(res, { license: status });
   }, 'license-status'));
 
   // Deactivate current license
-  router.post('/deactivate', ctx.asyncHandler(async (req, res) => {
-    const result = await ctx.licenseManager.deactivate();
+  router.post('/deactivate', asyncHandler(async (req, res) => {
+    const result = await licenseManager.deactivate();
 
     if (result.success) {
-      res.json({ success: true, message: result.message });
+      success(res, { message: result.message });
     } else {
-      ctx.errorResponse(res, 400, result.message);
+      errorResponse(res, result.message, 400);
     }
   }, 'license-deactivate'));
 
   // Check if a specific feature is available (lightweight check for frontend)
-  router.get('/feature/:feature', ctx.asyncHandler(async (req, res) => {
+  router.get('/feature/:feature', asyncHandler(async (req, res) => {
     const { feature } = req.params;
-    const available = ctx.licenseManager.hasFeature(feature);
-    const status = ctx.licenseManager.getStatus();
+    const available = licenseManager.hasFeature(feature);
+    const status = licenseManager.getStatus();
 
-    res.json({
-      success: true,
+    success(res, {
       feature,
       available,
       tier: status.tier,