v1.13.4: Standardize all route responses to use response helpers

Convert ~160 raw res.json()/res.status().json() calls across 32+ files
to use centralized helpers from src/utils/responses.js (ok, errorResponse,
successMessage, notFound, validationError, forbidden, unauthorized, conflict).

No behavior changes — response shapes are identical. Future schema changes
(e.g., requestId envelope) only need to update one module.

Fix error vs errorResponse signature mismatch in routes/health.js CA cert
endpoint where error(res, message, statusCode) was being called with
errorResponse(res, statusCode, message, extras) argument order.

Files changed: middleware.js, csrf-protection.js, error-handler.js,
license-manager.js, src/app.js, and 27 route files.

Test suite: 755 pass / 4 pre-existing failures (services credential tests).

dashcaddy-api/routes/arr/config.js

@@ -3,6 +3,7 @@ const { APP_PORTS, ARR_SERVICES } = require('../../constants');
 const { validateURL, validateToken } = require('../../input-validator');
 const { ValidationError, AuthenticationError, NotFoundError } = require('../../errors');
 const { logError } = require('../../src/utils/logging');
+const { ok, successMessage } = require('../../src/utils/responses');
 
 /**
  * Arr configuration routes factory
@@ -258,11 +259,7 @@ module.exports = function(ctx) {
         const version = service === 'plex' ? data.MediaContainer?.version : data.version;
         const appName = service === 'plex' ? 'Plex' : data.appName;
         log.info('arr', 'Service connection successful', { service, appName, version });
-        return res.json({
-          success: true,
-          version,
-          appName
-        });
+        return ok(res, { version, appName });
       } else if (response.status === 401) {
         throw new AuthenticationError('Invalid API key');
       } else if (response.status === 404) {
@@ -553,7 +550,7 @@ module.exports = function(ctx) {
       const metadata = await credentialManager.getMetadata(`arr.${service}.apikey`);
       const storedProfileId = metadata?.qualityProfileId || null;
 
-      res.json({ success: true, profiles: mapped, storedProfileId });
+      ok(res, { profiles: mapped, storedProfileId });
     } catch (e) {
       if (e.cause?.code === 'ECONNREFUSED') {
         return errorResponse(res, 502, 'Connection refused — is the service running?');
@@ -588,7 +585,7 @@ module.exports = function(ctx) {
     existing.qualityProfileName = qualityProfileName || null;
     await credentialManager.storeMetadata(credKey, existing);
 
-    res.json({ success: true, message: `Quality profile updated for ${service}` });
+    successMessage(res, `Quality profile updated for ${service}`);
   }, 'arr-quality-profile-save'));
 
   return router;

dashcaddy-api/routes/arr/credentials.js

@@ -1,6 +1,7 @@
 const express = require('express');
 const { validateURL, validateToken } = require('../../input-validator');
 const { ValidationError } = require('../../errors');
+const { ok, successMessage } = require('../../src/utils/responses');
 
 /**
  * Arr credentials routes factory
@@ -101,12 +102,7 @@ module.exports = function({ credentialManager, servicesStateManager, asyncHandle
 
     log.info('arr', 'Stored API key', { service, verified: connectionTest?.success || false });
 
-    res.json({
-      success: true,
-      message: `${service} API key stored`,
-      connectionTest,
-      url: resolvedUrl
-    });
+    ok(res, { message: `${service} API key stored`, connectionTest, url: resolvedUrl });
   }, 'arr-credentials-store'));
 
   // List stored arr credentials (keys only, not values)
@@ -131,7 +127,7 @@ module.exports = function({ credentialManager, servicesStateManager, asyncHandle
     // Get seedbox base URL
     const seedboxBaseUrl = await credentialManager.retrieve('arr.seedbox.baseurl');
 
-    res.json({ success: true, credentials, seedboxBaseUrl: seedboxBaseUrl || null });
+    ok(res, { credentials, seedboxBaseUrl: seedboxBaseUrl || null });
   }, 'arr-credentials-list'));
 
   // Delete stored arr credentials
@@ -140,7 +136,7 @@ module.exports = function({ credentialManager, servicesStateManager, asyncHandle
     const credKey = service === 'plex' ? 'arr.plex.token' : `arr.${service}.apikey`;
     await credentialManager.delete(credKey);
     log.info('arr', 'Deleted credentials', { service });
-    res.json({ success: true, message: `${service} credentials removed` });
+    successMessage(res, `${service} credentials removed`);
   }, 'arr-credentials-delete'));
 
   return router;

dashcaddy-api/routes/arr/detect.js

@@ -1,5 +1,6 @@
 const express = require('express');
 const { APP_PORTS, ARR_SERVICES } = require('../../constants');
+const { ok } = require('../../src/utils/responses');
 
 /**
  * Arr service detection routes factory
@@ -62,8 +63,7 @@ module.exports = function({ docker, servicesStateManager, credentialManager, fet
       detected.plex.token = await helpers.getPlexToken(detected.plex.containerName);
     }
 
-    res.json({
-      success: true,
+    ok(res, {
       services: detected,
       summary: {
         plexReady: !!(detected.plex?.token),
@@ -287,7 +287,7 @@ module.exports = function({ docker, servicesStateManager, credentialManager, fet
       readyForAutoConnect: statuses.filter(s => s.status === 'connected').length >= 2
     };
 
-    res.json({ success: true, services: result, seedboxBaseUrl: detectedSeedboxUrl, summary });
+    ok(res, { services: result, seedboxBaseUrl: detectedSeedboxUrl, summary });
   }, 'smart-detect'));
 
   return router;

dashcaddy-api/routes/arr/plex.js

@@ -1,5 +1,6 @@
 const express = require('express');
 const { APP_PORTS } = require('../../constants');
+const { ok } = require('../../src/utils/responses');
 
 /**
  * Plex routes factory
@@ -86,7 +87,7 @@ module.exports = function({ fetchT, asyncHandler, errorResponse, log: _log, help
       lastVerified: new Date().toISOString()
     });
 
-    res.json({ success: true, serverName, version, libraries });
+    ok(res, { serverName, version, libraries });
   }, 'plex-libraries'));
 
   return router;