v1.13.4: Standardize all route responses to use response helpers

Convert ~160 raw res.json()/res.status().json() calls across 32+ files
to use centralized helpers from src/utils/responses.js (ok, errorResponse,
successMessage, notFound, validationError, forbidden, unauthorized, conflict).

No behavior changes — response shapes are identical. Future schema changes
(e.g., requestId envelope) only need to update one module.

Fix error vs errorResponse signature mismatch in routes/health.js CA cert
endpoint where error(res, message, statusCode) was being called with
errorResponse(res, statusCode, message, extras) argument order.

Files changed: middleware.js, csrf-protection.js, error-handler.js,
license-manager.js, src/app.js, and 27 route files.

Test suite: 755 pass / 4 pre-existing failures (services credential tests).

dashcaddy-api/routes/config/assets.js

@@ -5,6 +5,7 @@ const { LIMITS } = require('../../constants');
 const { exists } = require('../../fs-helpers');
 const { ValidationError } = require('../../errors');
 const platformPaths = require('../../platform-paths');
+const { ok, successMessage } = require('../../src/utils/responses');
 /**
  * Config assets routes factory
  * @param {Object} deps - Explicit dependencies
@@ -63,8 +64,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
     const filePath = path.join(assetsPath, safeFilename);
     await fsp.writeFile(filePath, buffer);
 
-    res.json({
-      success: true,
+    ok(res, {
       path: `/assets/${safeFilename}`,
       message: `Logo saved to ${filePath}`
     });
@@ -76,8 +76,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
   // Get current logo path, position, and title
   router.get('/logo', asyncHandler(async (req, res) => {
     const config = await ctx.readConfig();
-    res.json({
-      success: true,
+    ok(res, {
       // Dark/light variants (new)
       customLogoDark: config.customLogoDark || null,
       customLogoLight: config.customLogoLight || null,
@@ -156,8 +155,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
     config.updatedAt = new Date().toISOString();
     await fsp.writeFile(ctx.CONFIG_FILE, JSON.stringify(config, null, 2), 'utf8');
 
-    res.json({
-      success: true,
+    ok(res, {
       pathDark: pathDark,
       pathLight: pathLight,
       // Legacy compat
@@ -195,10 +193,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
     config.updatedAt = new Date().toISOString();
     await fsp.writeFile(ctx.CONFIG_FILE, JSON.stringify(config, null, 2), 'utf8');
 
-    res.json({
-      success: true,
-      message: 'Branding reset to defaults'
-    });
+    successMessage(res, 'Branding reset to defaults');
   }, 'logo-delete'));
 
   // ===== FAVICON ENDPOINTS =====
@@ -207,8 +202,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
   // Get current favicon
   router.get('/favicon', asyncHandler(async (req, res) => {
     const config = await ctx.readConfig();
-    res.json({
-      success: true,
+    ok(res, {
       customFavicon: config.customFavicon || null,
       isDefault: !config.customFavicon
     });
@@ -268,8 +262,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
     // Update config
     await ctx.saveConfig({ customFavicon: '/assets/favicon.ico', updatedAt: new Date().toISOString() });
 
-    res.json({
-      success: true,
+    ok(res, {
       path: '/assets/favicon.ico',
       message: 'Favicon created successfully'
     });
@@ -293,10 +286,7 @@ module.exports = function({ servicesStateManager: _servicesStateManager, asyncHa
     config.updatedAt = new Date().toISOString();
     await fsp.writeFile(ctx.CONFIG_FILE, JSON.stringify(config, null, 2), 'utf8');
 
-    res.json({
-      success: true,
-      message: 'Favicon reset to default'
-    });
+    successMessage(res, 'Favicon reset to default');
   }, 'favicon-delete'));
 
   return router;

dashcaddy-api/routes/config/backup.js

@@ -5,6 +5,7 @@ const { CADDY } = require('../../constants');
 const { exists } = require('../../fs-helpers');
 const { ValidationError, AuthenticationError } = require('../../errors');
 const platformPaths = require('../../platform-paths');
+const { ok } = require('../../src/utils/responses');
 
 /**
  * Config backup routes factory
@@ -210,7 +211,7 @@ module.exports = function(deps) {
       preview.browserStateCount = Object.keys(backup.browserState).length;
     }
 
-    res.json({ success: true, preview });
+    ok(res, { preview });
   }, 'backup-preview'));
 
   // Restore configuration from backup
@@ -391,13 +392,17 @@ module.exports = function(deps) {
 
     const success = results.restored.length > 0 && results.errors.length === 0;
 
-    res.json({
-      success,
-      message: success
-        ? `Restored ${results.restored.length} file(s) successfully`
-        : `Restore completed with ${results.errors.length} error(s)`,
-      results
-    });
+    if (success) {
+      ok(res, {
+        message: `Restored ${results.restored.length} file(s) successfully`,
+        results
+      });
+    } else {
+      ok(res, {
+        message: `Restore completed with ${results.errors.length} error(s)`,
+        results
+      }, 200);
+    }
 
     log.info('backup', 'Backup restore completed', { restored: results.restored.length, errors: results.errors.length });
   }, 'backup-restore'));

dashcaddy-api/routes/config/settings.js

@@ -2,6 +2,7 @@ const fsp = require('fs').promises;
 const { validateConfig } = require('../../config-schema');
 const { exists } = require('../../fs-helpers');
 const { ValidationError } = require('../../errors');
+const { ok, successMessage } = require('../../src/utils/responses');
 
 /**
  * Config settings routes factory
@@ -71,14 +72,14 @@ module.exports = function({ configStateManager: _configStateManager, asyncHandle
     }
     log.info('config', 'Config saved', { path: ctx.CONFIG_FILE });
 
-    res.json({ success: true, message: 'Configuration saved', config, warnings });
+    ok(res, { message: 'Configuration saved', config, warnings });
   }, 'config-save'));
 
   router.delete('/config', asyncHandler(async (req, res) => {
     if (await exists(ctx.CONFIG_FILE)) {
       await fsp.unlink(ctx.CONFIG_FILE);
     }
-    res.json({ success: true, message: 'Configuration reset' });
+    successMessage(res, 'Configuration reset');
   }, 'config-delete'));
 
   return router;