From 55c405082a6208341beef3ce3ffac45a2c6535fa Mon Sep 17 00:00:00 2001 From: Krystie Date: Fri, 1 May 2026 02:36:31 -0700 Subject: [PATCH] fix: use TIMEOUTS constants instead of magic numbers in health and services routes - health.js: replace magic number 5000 with TIMEOUTS.HTTP_DEFAULT (twice) - services.js: replace magic number 5000 with TIMEOUTS.HTTP_DEFAULT Both files already import TIMEOUTS from constants but weren't using it. --- dashcaddy-api/routes/health.js | 4 ++-- dashcaddy-api/routes/services.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dashcaddy-api/routes/health.js b/dashcaddy-api/routes/health.js index fb8c82e..70ec60f 100644 --- a/dashcaddy-api/routes/health.js +++ b/dashcaddy-api/routes/health.js @@ -45,7 +45,7 @@ module.exports = function({ // Try HEAD first try { const controller = new AbortController(); - const timeout = setTimeout(() => controller.abort(), 5000); + const timeout = setTimeout(() => controller.abort(), TIMEOUTS.HTTP_DEFAULT); const response = await fetchT(url, { method: 'HEAD', signal: controller.signal, redirect: 'follow' }); clearTimeout(timeout); return { @@ -59,7 +59,7 @@ module.exports = function({ // Fallback to GET try { const controller = new AbortController(); - const timeout = setTimeout(() => controller.abort(), 5000); + const timeout = setTimeout(() => controller.abort(), TIMEOUTS.HTTP_DEFAULT); const response = await fetchT(url, { method: 'GET', signal: controller.signal, redirect: 'follow' }); clearTimeout(timeout); return { diff --git a/dashcaddy-api/routes/services.js b/dashcaddy-api/routes/services.js index 0cbbcb7..16e0f3a 100644 --- a/dashcaddy-api/routes/services.js +++ b/dashcaddy-api/routes/services.js @@ -113,7 +113,7 @@ module.exports = function({ const headers = {}; if (pylonConfig.key) headers['x-pylon-key'] = pylonConfig.key; const controller = new AbortController(); - const timeout = setTimeout(() => controller.abort(), 5000); + const timeout = setTimeout(() => controller.abort(), TIMEOUTS.HTTP_DEFAULT); const response = await fetchT(probeUrl, { method: 'GET', signal: controller.signal, headers }); clearTimeout(timeout); if (!response.ok) return null;