fix(lint): Add ctx shim to routes/apps and routes/arr

- routes/apps/deploy.js: Add ctx shim with APP_TEMPLATES, siteConfig, buildDomain, buildServiceUrl, addServiceToConfig, dns, notification, safeErrorMessage
- routes/apps/index.js: Extract additional ctx properties for sub-routes
- routes/arr/config.js: Add ctx shim with notification, safeErrorMessage + logError import
- routes/arr/index.js: Extract notification, safeErrorMessage for sub-routes

Result: Fixed ~30 no-undef errors (deploy.js 0 errors, arr/config.js 0 errors)

dashcaddy-api/routes/apps/deploy.js

@@ -7,6 +7,7 @@ const { isValidPort } = require('../../input-validator');
 const { exists } = require('../../fs-helpers');
 const platformPaths = require('../../platform-paths');
 const { ValidationError } = require('../errors');
+const { logError } = require('../../src/utils/logging');
 /**
  * Apps deployment routes factory
  * @param {Object} deps - Explicit dependencies
@@ -22,8 +23,20 @@ const { ValidationError } = require('../errors');
  * @returns {express.Router}
  */
 
-module.exports = function({ docker, caddy, credentialManager, servicesStateManager, portLockManager, asyncHandler, errorResponse, log, helpers }) {
+module.exports = function({ docker, caddy, credentialManager, servicesStateManager, portLockManager, asyncHandler, errorResponse, log, helpers, APP_TEMPLATES, siteConfig, buildDomain, buildServiceUrl, addServiceToConfig, dns, notification, safeErrorMessage }) {
   const router = express.Router();
+  
+  // Ctx shim for backward compatibility with existing route code
+  const ctx = {
+    APP_TEMPLATES,
+    siteConfig,
+    buildDomain,
+    buildServiceUrl,
+    addServiceToConfig,
+    dns,
+    notification,
+    safeErrorMessage
+  };
 
   async function deployDashCAStaticSite(template, userConfig) {
     const destPath = platformPaths.caCertDir;
@@ -260,6 +273,9 @@ module.exports = function({ docker, caddy, credentialManager, servicesStateManag
 
       let containerId;
       let usedExisting = false;
+      
+      // Process template variables for manifest (only needed for Docker containers)
+      const processedTemplate = template.isStaticSite ? null : helpers.processTemplateVariables(template, config);
 
       if (template.isStaticSite) {
         log.info('deploy', 'Deploying static site', { appId });

dashcaddy-api/routes/apps/index.js

@@ -23,7 +23,16 @@ module.exports = function(ctx) {
     portLockManager: ctx.portLockManager,
     asyncHandler: ctx.asyncHandler,
     errorResponse: ctx.errorResponse,
-    log: ctx.log
+    log: ctx.log,
+    // Additional context properties needed by routes
+    APP_TEMPLATES: ctx.APP_TEMPLATES,
+    siteConfig: ctx.siteConfig,
+    buildDomain: ctx.buildDomain,
+    buildServiceUrl: ctx.buildServiceUrl,
+    addServiceToConfig: ctx.addServiceToConfig,
+    dns: ctx.dns,
+    notification: ctx.notification,
+    safeErrorMessage: ctx.safeErrorMessage
   };
 
   // Initialize helpers with dependencies

dashcaddy-api/routes/arr/config.js

@@ -2,6 +2,7 @@ const express = require('express');
 const { APP_PORTS, ARR_SERVICES } = require('../../constants');
 const { validateURL, validateToken } = require('../../input-validator');
 const { ValidationError, AuthenticationError, NotFoundError } = require('../errors');
+const { logError } = require('../../src/utils/logging');
 
 /**
  * Arr configuration routes factory
@@ -16,8 +17,14 @@ const { ValidationError, AuthenticationError, NotFoundError } = require('../erro
  * @param {Object} deps.helpers - Arr helpers module
  * @returns {express.Router}
  */
-module.exports = function({ credentialManager, servicesStateManager, docker, fetchT, asyncHandler, errorResponse, log, helpers }) {
+module.exports = function({ credentialManager, servicesStateManager, docker, fetchT, asyncHandler, errorResponse, log, helpers, notification, safeErrorMessage }) {
   const router = express.Router();
+  
+  // Ctx shim for backward compatibility
+  const ctx = {
+    notification,
+    safeErrorMessage
+  };
 
   // Auto-configure Overseerr with detected services
   router.post('/arr/configure-overseerr', asyncHandler(async (req, res) => {

dashcaddy-api/routes/arr/index.js

@@ -17,7 +17,10 @@ module.exports = function(ctx) {
     fetchT: ctx.fetchT,
     asyncHandler: ctx.asyncHandler,
     errorResponse: ctx.errorResponse,
-    log: ctx.log
+    log: ctx.log,
+    // Additional context properties needed by arr routes
+    notification: ctx.notification,
+    safeErrorMessage: ctx.safeErrorMessage
   };
 
   // Initialize helpers with dependencies