[grade=A] P0-5: apps-revert catch — log err server-side, return generic 'Revert failed' to client

2026-08-08 03:35:55 -07:00
parent 57ed09fe91
commit 609ccd32c4
1 changed files with 5 additions and 1 deletions
@@ -293,7 +293,11 @@ module.exports = function({ docker, caddy, servicesStateManager, asyncHandler, e
        throw err;
      }
    } catch (err) {
-      errorResponse(res, 500, err.message);
+      // P0-5 fix: was `errorResponse(res, 500, err.message)` which leaks internal
+      // error details (paths, stack traces, library error codes) to the client.
+      // Log the actual error server-side and return a generic message.
+      log.error('apps-revert', 'Revert failed', { error: err.message, stack: err.stack });
+      errorResponse(res, 500, 'Revert failed');
    }
  }, 'apps-revert'));