sami7777/dashcaddy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(self-updater): clear all pending history entries, not just one

Browse Source 
checkPostUpdateResult() used history.find() which only ever updated a
single pending entry. When multiple update attempts stacked up, the
extra pending entries stayed stuck in 'pending' forever even though
the actual update completed. Switch to filter() + loop to clear all
matching entries.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sami
2026-05-06 01:58:44 -07:00
parent a216dd882d
commit 6abba43a80
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dashcaddy-api/self-updater.js
View File

@@ -313,11 +313,13 @@ class SelfUpdater extends EventEmitter {
// Update history // Update history
const history = this.getUpdateHistory(); const history = this.getUpdateHistory();
const pending = history.find(h => h.status === 'pending'); const updated = history.filter(h => h.status === 'pending');
if (pending) { if (updated.length > 0) {
pending.status = result.success ? 'success' : 'rolled-back'; for (const pending of updated) {
pending.duration = result.duration; pending.status = result.success ? 'success' : 'rolled-back';
if (result.error) pending.error = result.error; pending.duration = result.duration;
if (result.error) pending.error = result.error;
}
this._saveHistory(history); this._saveHistory(history);
} }