[glm-grade=A] fix(auto-restart): await async servicesStateManager.read() so handleContainerDown actually fires (DC-060)

dashcaddy-api/src/managers/auto-restart-manager.js

@@ -406,7 +406,7 @@ class AutoRestartManager extends EventEmitter {
     // Transition: healthy → unhealthy
     if (previousStatus === 'up' && currentStatus === 'down') {
       // Find the containerId from the health checker config or status details
-      const containerId = this._resolveContainerId(serviceId, status);
+      const containerId = await this._resolveContainerId(serviceId, status);
       if (containerId) {
         try {
           await this.handleContainerDown(serviceId, containerId);
@@ -429,12 +429,19 @@ class AutoRestartManager extends EventEmitter {
   /**
    * Attempt to find the containerId for a service from various sources.
    *
+   * DC-060: the previous implementation fired the async lookup via `.then(...)`
+   * but discarded the returned containerId, returning `undefined` from the
+   * function. Callers (`_handleStatusCheck`) gate on the return value, so
+   * every auto-restart whose containerId came from servicesStateManager
+   * silently no-op'd. Now awaits the read() promise so the containerId
+   * actually propagates.
+   *
    * @param {string} serviceId
    * @param {Object} status - The status-check event data
-   * @returns {string|null}
+   * @returns {Promise<string|null>}
    * @private
    */
-  _resolveContainerId(serviceId, status) {
+  async _resolveContainerId(serviceId, status) {
     // Check if it's in the status details (some health checks embed it)
     if (status.details?.containerId) return status.details.containerId;
 
@@ -442,23 +449,20 @@ class AutoRestartManager extends EventEmitter {
     const hcService = this.healthChecker?.config?.services?.[serviceId];
     if (hcService?.containerId) return hcService.containerId;
 
-    // Try to look it up from the services state manager
+    // Try to look it up from the services state manager. StateManager.read()
+    // is async (returns a Promise) — must await, not fire-and-forget.
     try {
       const servicesStateManager = this.ctx.servicesStateManager;
-      if (servicesStateManager) {
-        const readResult = servicesStateManager.read();
-        if (readResult && typeof readResult.then === 'function') {
-          // It returns a promise — fire-and-forget lookup
-          readResult.then(list => {
-            const found = (list || []).find(s => s.id === serviceId);
-            return found?.containerId || null;
-          }).catch(() => null);
-        } else {
-          const found = (readResult || []).find(s => s.id === serviceId);
-          if (found?.containerId) return found.containerId;
-        }
-      }
-    } catch (_) { /* best effort */ }
+      if (!servicesStateManager) return null;
+      const list = await servicesStateManager.read();
+      const found = (list || []).find(s => s.id === serviceId);
+      if (found?.containerId) return found.containerId;
+    } catch (err) {
+      // Best-effort: a state-manager read failure must not break the bridge.
+      // Surface at debug level so an operator hunting "why didn't auto-restart
+      // fire?" can find it without polluting the info-level event stream.
+      this.log?.debug?.('auto-restart', 'containerId resolve failed', { serviceId, error: err?.message });
+    }
 
     return null;
   }