DC-005: Fix all 138 broken test paths after src/ refactor

After the DC-005 module reorganization (41 files moved into src/ subdirs),
138 test suites failed because the refactor script's path-rewrite logic
missed three categories:

1. Files inside src/ doing 'require("./src/...")' — should be 'require("../...")'
2. Files in src/X/Y/ doing 'require("../../../src/...")' — should be 'require("../../...")'
3. Test files in __tests__/ with leftover 'require("../../../src/...")' paths

Root cause: the original refactor script ran before all files were moved,
so it computed relative paths against stale filesystem state.

Result:
- 30/30 test suites pass
- 879/879 tests pass (was: 18/30 suites, 614/687 tests)

Also fixed:
- routes/apps/restore.js: wrong responses import path
- routes/*/*.js: '../../src/utilities/X' → '../src/utilities/X' (depth 2 routes)
This commit is contained in:
Hermes
2026-06-13 12:16:56 -07:00
parent 9468dfc0eb
commit 7bc2a207f3
129 changed files with 591 additions and 310 deletions
@@ -1,12 +1,12 @@
// Mock dependencies before requiring the module
jest.mock('../keychain-manager', () => ({
jest.mock('../src/security/keychain-manager', () => ({
available: false,
store: jest.fn().mockResolvedValue(false),
retrieve: jest.fn().mockResolvedValue(null),
delete: jest.fn().mockResolvedValue(true),
}));
jest.mock('../crypto-utils', () => ({
jest.mock('../src/security/crypto-utils', () => ({
encrypt: jest.fn(data => `enc:tag:${Buffer.from(String(data)).toString('base64')}`),
decrypt: jest.fn(data => {
const parts = data.split(':');
@@ -40,8 +40,8 @@ describe('CredentialManager', () => {
// Re-get mocked modules
fs = require('fs');
lockfile = require('proper-lockfile');
keychainManager = require('../keychain-manager');
cryptoUtils = require('../crypto-utils');
keychainManager = require('../src/security/keychain-manager');
cryptoUtils = require('../src/security/crypto-utils');
// Reset mock implementations
fs.existsSync.mockReturnValue(true);
@@ -50,7 +50,7 @@ describe('CredentialManager', () => {
lockfile.lock.mockResolvedValue(jest.fn().mockResolvedValue());
keychainManager.available = false;
credentialManager = require('../credential-manager');
credentialManager = require('../src/managers/credential-manager');
credentialManager.cache.clear();
});
@@ -72,10 +72,10 @@ describe('CredentialManager', () => {
fs.writeFileSync.mockImplementation(() => {});
lockfile = require('proper-lockfile');
lockfile.lock.mockResolvedValue(jest.fn().mockResolvedValue());
keychainManager = require('../keychain-manager');
keychainManager = require('../src/security/keychain-manager');
keychainManager.available = true;
keychainManager.store.mockResolvedValue(true);
credentialManager = require('../credential-manager');
credentialManager = require('../src/managers/credential-manager');
const result = await credentialManager.store('test.key', 'value');
expect(result).toBe(true);
@@ -91,11 +91,11 @@ describe('CredentialManager', () => {
fs.writeFileSync.mockImplementation(() => {});
lockfile = require('proper-lockfile');
lockfile.lock.mockResolvedValue(jest.fn().mockResolvedValue());
keychainManager = require('../keychain-manager');
keychainManager = require('../src/security/keychain-manager');
keychainManager.available = true;
keychainManager.store.mockResolvedValue(false);
cryptoUtils = require('../crypto-utils');
credentialManager = require('../credential-manager');
cryptoUtils = require('../src/security/crypto-utils');
credentialManager = require('../src/managers/credential-manager');
const result = await credentialManager.store('test.key', 'value');
expect(result).toBe(true);