[grade=A] DC-065: Sweep 15 console.* calls to process.stderr.write
CI / Test & Lint (push) Canceled after 0s
CI / Security audit (push) Canceled after 0s

Replace all non-logger console.error/warn calls with process.stderr.write
using tagged prefixes ([AuditLogger], [CSRF], [DNS Registry], etc.) for
grep-ability. All in fallback/catch paths where structured logger may be
unavailable. Test updated to use jest.spyOn with try/finally for clean
mock restoration.

Codex grade: pass (22,402 tokens). All 1539 tests pass.
This commit is contained in:
Hermes
2026-08-12 04:50:16 -07:00
parent a1d7208686
commit 92482980dd
10 changed files with 26 additions and 30 deletions
+3 -3
View File
@@ -184,10 +184,10 @@ class AuditLogger {
});
} catch (e) {
// Non-fatal — security store is a best-effort mirror
console.error('[AuditLogger] Security event emit failed:', e.message);
process.stderr.write(`[AuditLogger] Security event emit failed: ${e.message}\n`);
}
} catch (e) {
console.error('[AuditLogger] Failed to write entry:', e.message);
process.stderr.write(`[AuditLogger] Failed to write entry: ${e.message}\n`);
}
}
@@ -199,7 +199,7 @@ class AuditLogger {
}
return entries.slice(offset, offset + limit);
} catch (e) {
console.error('[AuditLogger] Failed to read:', e.message);
process.stderr.write(`[AuditLogger] Failed to read: ${e.message}\n`);
return [];
}
}
@@ -216,14 +216,14 @@ function csrfValidationMiddleware(req, res, next) {
// Validate both values exist
if (!cookieNonce) {
console.warn(`[CSRF] Missing CSRF cookie: ${method} ${req.path} from ${req.ip}`);
process.stderr.write(`[CSRF] Missing CSRF cookie: ${method} ${req.path} from ${req.ip}\n`);
return errorResponse(res, 403, '[DC-100] CSRF token missing', {
message: 'CSRF cookie not found. Please refresh the page (Ctrl+Shift+R) and try again.'
});
}
if (!headerToken) {
console.warn(`[CSRF] Missing CSRF header: ${method} ${req.path} from ${req.ip}`);
process.stderr.write(`[CSRF] Missing CSRF header: ${method} ${req.path} from ${req.ip}\n`);
return errorResponse(res, 403, '[DC-100] CSRF token missing', {
message: 'CSRF token not provided in request headers. Please refresh the page (Ctrl+Shift+R) and try again.'
});
@@ -247,7 +247,7 @@ function csrfValidationMiddleware(req, res, next) {
next();
} catch (err) {
console.warn(`[CSRF] Invalid CSRF token: ${method} ${req.path} from ${req.ip} - ${err.message}`);
process.stderr.write(`[CSRF] Invalid CSRF token: ${method} ${req.path} from ${req.ip} - ${err.message}\n`);
return errorResponse(res, 403, '[DC-101] CSRF token invalid', {
message: 'CSRF token validation failed. Please refresh the page (Ctrl+Shift+R) and try again.'
});