sami7777/dashcaddy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: always expose DC-prefixed errors to users in safeErrorMessage
CI / Test & Lint (push) Has been cancelled
Details
CI / Security audit (push) Has been cancelled
Details

Browse Source
This commit is contained in:
Hermes
2026-06-10 17:02:13 -07:00
parent bda08b592e
commit aa25bcc053
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dashcaddy-api/src/utils/logging.js
+4 -1
View File
@@ -97,6 +97,9 @@ function safeErrorMessage(error) {
if (!error) return 'An internal error occurred'; if (!error) return 'An internal error occurred';
const msg = error.message || String(error); const msg = error.message || String(error);
// Always expose DC-prefixed user-facing errors
if (/\[DC-\d+\]/.test(msg)) return msg;
// Detect port conflict errors // Detect port conflict errors
const portMatch = msg.match(/exposing port TCP [^:]*:(\d+)/); const portMatch = msg.match(/exposing port TCP [^:]*:(\d+)/);
if (portMatch || msg.includes('port is already allocated') || msg.includes('ports are not available')) { if (portMatch || msg.includes('port is already allocated') || msg.includes('ports are not available')) {
@@ -104,7 +107,7 @@ function safeErrorMessage(error) {
return `[DC-200] Port ${port} is already in use. Try a different port or stop the service using that port first.`; return `[DC-200] Port ${port} is already in use. Try a different port or stop the service using that port first.`;
} }
// Only expose short, user-facing messages // Only expose short, user-facing messages (no paths, stack traces, or internal details)
if (msg.length < 200 && !msg.includes('/') && !msg.includes('\\') && !msg.includes(' at ')) { if (msg.length < 200 && !msg.includes('/') && !msg.includes('\\') && !msg.includes(' at ')) {
return msg; return msg;
} }