fix(updater): stop false-positive "update available" loop when commit is unknown

Dockerfile never received DASHCADDY_COMMIT at build, so /app/VERSION held
'unknown'. _isNewer then treated same-version-different-commit as newer,
making the auto-updater rebuild the container indefinitely (each rebuild
still produced commit='unknown').

- self-updater._isNewer: normalize commits; treat unknown/null/empty as no
  commit info and fall back to pure version comparison
- self-updater._autoCheckAndApply + routes/updates: refuse to apply when
  local version >= remote version (belt-and-suspenders)
- update-management.js: hide '(unknown)' from version label
- Dockerfile: COPY VERSION instead of writing from build arg
- VERSION: committed placeholder ('dev'); scripts/release.sh now writes
  the real short SHA into the tarball's VERSION before tar-ing, so every
  published release ships with an accurate commit

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Sami
2026-05-12 18:20:59 -07:00
co-authored by Claude Opus 4.7
parent 88206ff215
commit f65af5d7fd
6 changed files with 46 additions and 10 deletions
+2 -1
View File
@@ -335,7 +335,8 @@
const res = await fetch('/api/v1/system/version');
const data = await res.json();
if (data.success) {
dcVersionInfo.textContent = 'v' + data.version + (data.commit ? ' (' + data.commit.substring(0, 7) + ')' : '');
const commit = data.commit && data.commit !== 'unknown' ? data.commit : null;
dcVersionInfo.textContent = 'v' + data.version + (commit ? ' (' + commit.substring(0, 7) + ')' : '');
}
} catch (_) {
dcVersionInfo.textContent = 'Unable to fetch version';