Krystie
0c658a26a8
fix(routes): complete post-refactor dependency wiring cleanup
2026-05-04 16:44:18 -07:00
4c2e4ed986
fix: resolve ctx naming conflict in arr/config.js, add pylon to known config keys
...
- Remove redundant ctx shim that conflicted with function parameter
- Use destructured notification/safeErrorMessage directly
- Add pylon, customLogoDark, customLogoLight to known config keys
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-30 03:23:59 -07:00
f865790fe1
fix(routes): restore ctx access in 15 route files broken by Phase 2.1 refactor
...
The modular refactor changed function signatures to destructured deps but
left internal ctx.* references intact, causing "ctx is not defined" errors
on /api/config, /api/logo, and many other endpoints. Also implements
loadTotpConfig and saveTotpConfig which were left as stubs.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-03-30 03:01:29 -07:00
Krystie
564c442ea4
fix(routes): Correct require paths for errors.js in subdirectory routes
2026-03-30 00:21:25 -07:00
Krystie
5baa97bbf9
fix(lint): Add ctx shim to routes/apps and routes/arr
...
- routes/apps/deploy.js: Add ctx shim with APP_TEMPLATES, siteConfig, buildDomain, buildServiceUrl, addServiceToConfig, dns, notification, safeErrorMessage
- routes/apps/index.js: Extract additional ctx properties for sub-routes
- routes/arr/config.js: Add ctx shim with notification, safeErrorMessage + logError import
- routes/arr/index.js: Extract notification, safeErrorMessage for sub-routes
Result: Fixed ~30 no-undef errors (deploy.js 0 errors, arr/config.js 0 errors)
2026-03-29 22:35:13 -07:00
Krystie
6bde2eb62e
Refactor arr routes: explicit dependency injection
...
- Updated all arr route modules to use destructured dependencies
- Added JSDoc comments for factory functions
- Replaced ctx. references with direct parameter access
- Updated arr/index.js to extract and pass explicit dependencies
- Maintained backward compatibility with context pattern
- All files pass syntax validation
Files refactored:
- routes/arr/detect.js
- routes/arr/credentials.js
- routes/arr/config.js (579 lines)
- routes/arr/smart-connect.js
- routes/arr/plex.js
- routes/arr/helpers.js
- routes/arr/index.js (orchestrator)
2026-03-29 21:30:41 -07:00
Krystie
b172a21b63
Migrate 25 route files to throw-based error handling
...
Converted routes:
- All auth routes (totp.js, keys.js, sso-gate.js)
- Recipe deployment routes (deploy.js, manage.js, index.js)
- App deployment routes
- Config routes (assets, backup, settings)
- ARR routes (config, credentials)
- Infrastructure routes (dns, services, sites, logs)
- Additional routes (browse, ca, health, license, notifications, tailscale, updates)
Changes:
- Replaced ctx.errorResponse() with throw statements
- Replaced errorResponse() with throw statements
- Added proper error imports to each file
- 400 errors → ValidationError
- 401 errors → AuthenticationError
- 403 errors → ForbiddenError
- 404 errors → NotFoundError
- 409 errors → ConflictError
- 500 errors → Handled by middleware
Result: 25 files migrated, ~150 error responses standardized
2026-03-29 18:53:03 -07:00
6c3848102b
refactor: Phase 1 code cleanup - constants, logging, and repository organization
2026-03-28 18:54:39 -07:00
f61e85d9a7
Initial commit: DashCaddy v1.0
...
Full codebase including API server (32 modules + routes), dashboard frontend,
DashCA certificate distribution, installer script, and deployment skills.
2026-03-05 02:26:12 -08:00
