2 Commits

Include renames

Author	SHA1	Message	Date
Hermes	f750d01ed0	DC-039: route all module file defaults through platformPaths.dataDir ... Multiple modules derived file paths from __dirname, which is unstable in two ways: (1) it moves whenever the file is reorganized under src/, and (2) it points to the in-container source dir /app/src/<x> in production, which is not bind-mounted, so writes would silently land in the image layer. Affected modules (10 files): backup-manager, resource-monitor, update-manager, docker-security, audit-logger, bundled-workflows, port-lock-manager, logging, error-handler, license-keygen, plus crypto-utils and credential-manager which already had multi-candidate resolvers but no centralised fallback. Introduced platformPaths.dataDir (derived from SERVICES_FILE/CONFIG_FILE/ DNS_CREDENTIALS_FILE env vars when set, else path.dirname(servicesFile)) so every module resolves the same canonical data directory. Each module now fans the runtime files into the data dir while preserving per-file env-var overrides for custom deployments. Why a single resolver: - one place to swap the default path scheme in v2.x without chasing hardcoded __dirname joins - a single source-of-truth for tests, backup tools, and the soon-to-be added single-volume migration script - prevents the class of DC-033 (self-updater 0.0.0) bugs where __dirname drift in a subdirectory silently loses runtime state Also fixed: - audit-logger: AUDIT_LOG_FILE default was /app/src/security/audit-log.json (writable in dev, image-layer in production). Now /app/data/audit-log.json via platformPaths.dataDir, matching logging.js's same file. Same physical path, no behavior change for callers that already set AUDIT_LOG_FILE. - logging.js: LOG_DIR was __dirname (src/utils/) — error.log and audit-log.json were being written into the source tree. Now platformPaths.dataDir, matching every other persistent file. - error-handler.js: ERROR_LOG_FILE hard-coded to __dirname/error.log (src/utilities/error.log), redundant with logging.js's own default. Now platformPaths.dataDir/error.log. - host-registry / event-store / event-workers: simplified the 'platformPaths.dataDir || path.join(__dirname, ../../data)' pattern to just platformPaths.dataDir (the legacy fallback is no longer reachable — services.json lives at dataDir/services.json now). - public-routes-drift.test.js: added 'routes/security.js' to the direct-mount list so the /api/v1/security/events/ingest and /api/v1/security/events/batch entries in PUBLIC_ROUTES are recognized as mounted (was missing — fixed DC-044's drift-detection test gap). Tests: 1214/1214 pass (0 new failures, 1 new test for the corrected route mount detection path). ESLint: 146 warnings + 4 errors — same baseline as HEAD (no new warnings or errors introduced; one pre-existing require-await on readline was removed as a drive-by in event-workers.js since the module uses line-level fs reads, not readline). Container config files like audit-log.json, container-stats.json, and workflow-history.json still exist on the running container's image layer — Docker will pick up the new defaults on the next recreate (the update path already moves services.json+config.json+credentials.json via the data bind mount).	2026-07-13 08:59:38 -07:00
Hermes	ab0ef9cfa1	DC-017: Regression tests for depth-2 route paths + PUBLIC_ROUTES drift ... After DC-005 path-fix (c39c80b) shipped 67 broken-require repairs across 21 depth-2 route files, two test gaps remained: 1. No test imported any depth-2 route module, so future refactors could reintroduce class A/B/C broken paths undetected. 2. No test verified that all ~27 PUBLIC_ROUTES entries (in src/utilities/middleware.js) corresponded to actually-mounted routes. DC-012 added a similar check for the 5 probe paths, but only those. Added 3 files, fixed 1 test helper, no production code changed: - __tests__/depth2-routes-smoke.test.js (new): discovers every .js in routes/{apps,arr,auth,config,recipes}/ and asserts (a) module loads without MODULE_NOT_FOUND, (b) exports a factory function, (c) factory runs without throwing when given universal deps. Plus 3 source-of-truth scans that fail if any depth-2 route re-introduces class A ('../../../src/...'), class B ('../src/...'), or class C ('utilities/responses' instead of 'utils/responses') require paths. - __tests__/public-routes-drift.test.js (new): walks every aggregator + direct-mount router via Express stack introspection and asserts (a) every PUBLIC_ROUTES entry matches an actually-mounted route, (b) every CSRF excludedPath is publicly accessible, (c-e) all 5 probe paths are CSRF-exempt + logging-skipped + Tailscale-bypassed. - __tests__/test-helpers/universal-deps.js (new): Proxy + seed-object shared by both suites. Returns sensible stubs for any property access (logger-shaped object, asyncHandler pass-through, path-string stubs). Supports Object.assign/spread via ownKeys+getOwnPropertyDescriptor traps so aggregator factories that copy ctx into subCtx don't lose proxy magic. Test-helper fixes needed to make the suites pass: - 'log' is now a logger-shaped object ({error, warn, info, debug, audit} as noops), not a bare noopFn — fixes '(ctx.log || console).error(...)' in routes/apps/index.js factory catch block. - 'asyncHandler' seeded as own enumerable property — survives Object.assign({}, ctx, { helpers }) used by routes/arr/index.js etc. - Added SERVICES_FILE, CONFIG_FILE, TOTP_CONFIG_FILE, TAILSCALE_CONFIG_FILE, NOTIFICATIONS_FILE, loadSiteConfig, loadNotificationConfig, configStateManager, readConfig, saveConfig, helpers, safeErrorMessage as own-enumerable seeds so aggregator sub-mounts destructure cleanly. Public-routes-drift test fixes: - Aggregator walks use prefix '/api/v1' (matches src/app.js's bare-mount on apiRouter at /api/v1). Without this, the 6 TOTP routes registered by routes/auth/index.js appeared as '/totp/config' instead of '/api/v1/totp/config' and were falsely flagged as stale. - Direct-mount walks use '/api/v1' + explicit prefixMap entry (same reason). - Added routes/themes.js and routes/license.js to directMounts. Result: 35 suites, 1036 tests, all passing (was 1030 passing + 6 failing before this commit). The 6 pre-existing failures were depth-2 factory errors + 22 PUBLIC_ROUTES stale entries that the test infrastructure was silently swallowing — these tests surface them so they can't recur. BACKLOG.md updated with full DC-017 entry (status: done, owner: krystie).	2026-06-26 12:16:38 -07:00