3 Commits

Include renames

Author	SHA1	Message	Date
Hermes	97672f7e74	[glm-grade=A] fix(notifications): un-gate 7 dead emitters + repair legacy 4-arg send shape (DC-094) ... Two silent-death defects in one class: 1. Seven emitters absent from DEFAULT events, so the send() gate (config.events[canonical] !== true) dropped them on every install: ssl-cert-expiry, dns-propagation, drift-detected, dependency-restart-complete/-failed, recipeRemoved, workflow. All now default ON; dependency-restart spellings fold onto one canonical toggle; recipeRemoved aliases to recipe-removed in both the manager and route alias maps. 2. Nine call sites used a legacy 4-arg send(event, title, message, type) against the 3-arg signature: the message string landed in the type slot (Discord embed color fell back to info-blue, history.type wrong) and providers received the TITLE as the body - deploy-failure notifications carried no error text at all. Fixed at source (9 sites) plus a type-guarded shim in send() for external legacy callers. Also: explicit data.title now flows to ntfy Title header, email subject, Discord embed title, and history; settings UI gains 9 event toggles (separate Backup Complete/Failed) with defaults-on semantics. Tests: +24 (new DC-094 suite: defaults, gate pass-through, alias folding send-time and load-time, stored-config inheritance, shim body/title/ color/subject/history, type-guard, 3-arg no-regression); 4 assertions in bundled-workflows-health-check updated from the old 4-arg mock contract to the canonical shape (same behavior asserted). Full suite 116 suites / 2706 tests green. Judge: GLM-5.3 cold read via delegate_task (deleg_8a7cedd0), grade A, zero blockers; 2 polish items (Backups toggle conflation, shim type-guard) folded into this commit. Verdict URN: urn:ump:uyipjjwdjqjy3alvceqxvlucrymd7hnsben5udpp2bqycoh3l2la	2026-08-22 19:42:25 -07:00
Hermes	be798a9bc2	[grade=B] fix(workflows): DC-044 root-cause — gate notify-on-failure, interpolate failingServices, fix Health.Status check ... The original DC-044 fix (b492e1c) repaired servicesStateManager.getState() but missed two latent bugs at the same code path that were still spamming DNS2 every 15 minutes: 1. notify-on-failure fired unconditionally. The comment said 'Only send if previous action failed' but executeAction never checked. Every health-check-on-interval cycle ran notify regardless of outcome. 2. {{serviceId}} template never interpolated. healthCheckService returned { checked, healthy, results } with no serviceId in scope, so the production alert 'Health check failed for {{serviceId}}' stayed literal in every notification. 3. checkContainerHealth compared info.State.Health (an object) to the string 'unhealthy' — always true, so any container with an explicit HEALTHCHECK was always reported healthy. Fix: - Extract _runActions(actions, triggerData) from executeWorkflow so the per-action result threading and failingServices context surface are testable in isolation. - Gate notify-on-failure on previousResult.success === false. Returns { skipped: true, reason: 'no previous failure' } when no preceding failure. - healthCheckService throws an Error with .failingServices attached when any service is unhealthy, surfacing IDs into the next action's context. - checkContainerHealth now reads info.State.Health.Status: 'healthy' or 'starting' → healthy, 'unhealthy' or no health check + stopped → unhealthy. - Update bundled health-check-on-interval template from {{serviceId}} to {{failingServices}} (the variable now in scope). Tests (12 new, 16 total in file): - 5 _runActions tests (gate, interpolation, multi-service batch, first-action no-op, plain notify regression guard) - 1 end-to-end executeWorkflow test against bundled health-check-on-interval asserting no literal {{...}} tokens reach notification.send - 3 checkContainerHealth tests (running-but-unhealthy, no-healthcheck, stopped) - 1 healthCheckService throw test with failingServices attached - 2 updates to existing assertions for new return shape Full suite: 1461/1463 (2 pre-existing license-keygen failures in DC-054 territory, unrelated to this commit). Co-graded: Codex B urn:ump:b2nzzoulodwsullt3rhz4mtzou7fqgwiuoyrzxho67gdpwx3uvaa	2026-07-31 00:43:29 -07:00
Hermes	b492e1cd4f	DC-044: fix WorkflowEngine healthCheckService — servicesStateManager.getState bug ... The bundled-workflows.js:310 call site used a non-existent .getState() method AND forgot to await. The Promise short-circuited via '|| []' to an empty array, so every health-check-on-interval workflow ran every 5 min reporting 'Action health-check failed: servicesStateManager.getState is not a function' while silently iterating over zero services. Visible on both DNS2 (production) and dc-contabo-de (test server) — same code, same bug, same log spam. Fix: 'await servicesStateManager.read().catch(() => []) || []' — uses the actual async method, returns empty array on read() failure (corrupt or missing state file shouldn't break the workflow), preserves the original short-circuit guard. New regression test __tests__/bundled-workflows-health-check.test.js with 5 cases: 1. uses .read() not the non-existent .getState() — does not throw 2. returns checked/healthy counts from read() output 3. gracefully degrades if read() throws — empty services list, no crash 4. servicesStateManager absent on ctx → no crash, empty result 5. single service (non-template serviceId) path still works Tests: 1219/1219 pass (1214 baseline + 5 new). ESLint: clean for the new file. Test fixture note: had to clearInterval the constructor's scheduledJobs so Jest could exit cleanly — scheduled workflows are not under test here.	2026-07-13 15:38:11 -07:00