2 Commits

Include renames

Author	SHA1	Message	Date
Hermes	f750d01ed0	DC-039: route all module file defaults through platformPaths.dataDir ... Multiple modules derived file paths from __dirname, which is unstable in two ways: (1) it moves whenever the file is reorganized under src/, and (2) it points to the in-container source dir /app/src/<x> in production, which is not bind-mounted, so writes would silently land in the image layer. Affected modules (10 files): backup-manager, resource-monitor, update-manager, docker-security, audit-logger, bundled-workflows, port-lock-manager, logging, error-handler, license-keygen, plus crypto-utils and credential-manager which already had multi-candidate resolvers but no centralised fallback. Introduced platformPaths.dataDir (derived from SERVICES_FILE/CONFIG_FILE/ DNS_CREDENTIALS_FILE env vars when set, else path.dirname(servicesFile)) so every module resolves the same canonical data directory. Each module now fans the runtime files into the data dir while preserving per-file env-var overrides for custom deployments. Why a single resolver: - one place to swap the default path scheme in v2.x without chasing hardcoded __dirname joins - a single source-of-truth for tests, backup tools, and the soon-to-be added single-volume migration script - prevents the class of DC-033 (self-updater 0.0.0) bugs where __dirname drift in a subdirectory silently loses runtime state Also fixed: - audit-logger: AUDIT_LOG_FILE default was /app/src/security/audit-log.json (writable in dev, image-layer in production). Now /app/data/audit-log.json via platformPaths.dataDir, matching logging.js's same file. Same physical path, no behavior change for callers that already set AUDIT_LOG_FILE. - logging.js: LOG_DIR was __dirname (src/utils/) — error.log and audit-log.json were being written into the source tree. Now platformPaths.dataDir, matching every other persistent file. - error-handler.js: ERROR_LOG_FILE hard-coded to __dirname/error.log (src/utilities/error.log), redundant with logging.js's own default. Now platformPaths.dataDir/error.log. - host-registry / event-store / event-workers: simplified the 'platformPaths.dataDir || path.join(__dirname, ../../data)' pattern to just platformPaths.dataDir (the legacy fallback is no longer reachable — services.json lives at dataDir/services.json now). - public-routes-drift.test.js: added 'routes/security.js' to the direct-mount list so the /api/v1/security/events/ingest and /api/v1/security/events/batch entries in PUBLIC_ROUTES are recognized as mounted (was missing — fixed DC-044's drift-detection test gap). Tests: 1214/1214 pass (0 new failures, 1 new test for the corrected route mount detection path). ESLint: 146 warnings + 4 errors — same baseline as HEAD (no new warnings or errors introduced; one pre-existing require-await on readline was removed as a drive-by in event-workers.js since the module uses line-level fs reads, not readline). Container config files like audit-log.json, container-stats.json, and workflow-history.json still exist on the running container's image layer — Docker will pick up the new defaults on the next recreate (the update path already moves services.json+config.json+credentials.json via the data bind mount).	2026-07-13 08:59:38 -07:00
Hermes	29f2c7999f	DC-020: restore license-keygen.js + fix broken require paths (container crash-loop) ... The refactor(desloppify) commit a2e6566 deleted license-keygen.js and added it to .gitignore, believing it was stale dev-root noise. It is actually a required production module: src/managers/license-manager.js does require('./license-keygen') and imports verifyCode/parseCode/VALID_DURATIONS. The deletion put the production dashcaddy-api container in a crash-restart loop (MODULE_NOT_FOUND from /app/src/app.js -> /app/server.js). The 1036-test suite passed because no test ever executed require() on the real app module. Fixes: - Restore license-keygen.js from git history (a2e6566^) to src/managers/, the path the post-DC-005 require resolves to. CLI main() is require.main-guarded, so only the library exports are used at runtime. - Remove the license-keygen.js line from .gitignore so the restored module is tracked (otherwise the fix would not survive a container rebuild). - Fix a second masked broken require: src/docker/self-updater.js required './platform-paths' (resolves to src/docker/, doesn't exist) -> corrected to '../../platform-paths' (repo root, where all 9 other callers point). - Add .encryption-key to .gitignore (runtime AES secret that the require graph regenerates; was untracked + un-ignored -> latent leak on git add -A). - Add __tests__/app-startup-smoke.test.js: executes require() on the real app module and asserts the full require graph resolves. This regression guard would have caught both broken requires. Verified: app module now loads clean; 1038/1038 tests pass (+2 new); the smoke test fails if either required module is missing.	2026-06-29 07:22:33 -07:00