sami7777/dashcaddy
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

P7 people-store providerUserId dedupe #4

Merged
sami7777 merged 1 commits from p7-people-dedupe into main 2026-10-04 12:14:44 +02:00
Conversation 0 Commits 1 Files Changed 2
+31 -1
sami7777 commented 2026-10-04 12:14:42 +02:00
Owner
Copy link
Copy source

Dogfood finding #3. Judge B r1 urn:ump:bbfbsfru4nizg75wcxum7mwzhie6txhr22hw6jvz36wiihmgzmlq. 3414/3414.

Dogfood finding #3. Judge B r1 urn:ump:bbfbsfru4nizg75wcxum7mwzhie6txhr22hw6jvz36wiihmgzmlq. 3414/3414.
sami7777 added 1 commit 2026-10-04 12:14:42 +02:00
[grade=B urn:ump:bbfbsfru4nizg75wcxum7mwzhie6txhr22hw6jvz36wiihmgzmlq] P7 people store: dedupe upsert by providerUserId
CI / Security audit (pull_request) Canceled after 0s
Details
CI / Test & Lint (pull_request) Canceled after 0s
Details
c430e02117 
Dogfood finding #3: upsertPerson resolved existing records by id only.
The wizard upserts a bootstrap admin AFTER a provider sync has already
created a person for the same Tailscale user (no id passed), so the same
providerUserId was duplicated into two records. Resolve existing by
providerUserId when no id is given; bootstrap Admin group + protectedAt are
preserved on the merge. New regression test; full suite 3414/3414.
sami7777 merged commit 0fd1bbd80b into main 2026-10-04 12:14:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
sami7777
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sami7777/dashcaddy#4