Hermes
7bc2a207f3
After the DC-005 module reorganization (41 files moved into src/ subdirs),
138 test suites failed because the refactor script's path-rewrite logic
missed three categories:
1. Files inside src/ doing 'require("./src/...")' — should be 'require("../...")'
2. Files in src/X/Y/ doing 'require("../../../src/...")' — should be 'require("../../...")'
3. Test files in __tests__/ with leftover 'require("../../../src/...")' paths
Root cause: the original refactor script ran before all files were moved,
so it computed relative paths against stale filesystem state.
Result:
- 30/30 test suites pass
- 879/879 tests pass (was: 18/30 suites, 614/687 tests)
Also fixed:
- routes/apps/restore.js: wrong responses import path
- routes/*/*.js: '../../src/utilities/X' → '../src/utilities/X' (depth 2 routes)
93 lines
2.7 KiB
JavaScript
93 lines
2.7 KiB
JavaScript
/**
|
||
* Config Drift Detection Routes
|
||
*
|
||
* API endpoints for running drift detection, reading cached reports,
|
||
* auto-fixing drift, and controlling periodic polling.
|
||
*
|
||
* @module routes/config-drift
|
||
*/
|
||
|
||
const express = require('express');
|
||
const { success } = require('../src/utils/responses');
|
||
const { ValidationError, NotFoundError } = require('../src/utilities/errors');
|
||
|
||
/**
|
||
* Config-drift route factory
|
||
*
|
||
* @param {Object} deps - Explicit dependencies
|
||
* @param {Object} deps.driftDetector - ConfigDriftDetector instance
|
||
* @param {Function} deps.asyncHandler - Async route handler wrapper
|
||
* @param {Function} deps.logError - Error logging function
|
||
* @returns {express.Router}
|
||
*/
|
||
module.exports = function ({ driftDetector, asyncHandler, logError }) {
|
||
const router = express.Router();
|
||
|
||
/**
|
||
* GET /config-drift/report
|
||
* Run a fresh drift detection and return the full report.
|
||
*/
|
||
router.get('/report', asyncHandler(async (_req, res) => {
|
||
const report = await driftDetector.detect();
|
||
success(res, { report });
|
||
}, 'drift-report'));
|
||
|
||
/**
|
||
* GET /config-drift/last
|
||
* Return the last cached drift report (no re-detection).
|
||
*/
|
||
router.get('/last', asyncHandler(async (_req, res) => {
|
||
if (!driftDetector.lastReport) {
|
||
throw new NotFoundError('No cached drift report — run detection first');
|
||
}
|
||
|
||
success(res, { report: driftDetector.lastReport });
|
||
}, 'drift-last'));
|
||
|
||
/**
|
||
* POST /config-drift/fix
|
||
* Auto-fix detected drift: remove stale records, flag unknown containers.
|
||
*/
|
||
router.post('/fix', asyncHandler(async (_req, res) => {
|
||
const result = await driftDetector.autoFix();
|
||
success(res, {
|
||
message: 'Auto-fix applied',
|
||
staleRemoved: result.staleRemoved,
|
||
unknownFlagged: result.unknownFlagged,
|
||
});
|
||
}, 'drift-fix'));
|
||
|
||
/**
|
||
* POST /config-drift/polling
|
||
* Enable or disable periodic drift detection polling.
|
||
*
|
||
* Body: { enabled: boolean, intervalMs?: number }
|
||
*/
|
||
router.post('/polling', asyncHandler(async (req, res) => {
|
||
const { enabled, intervalMs } = req.body;
|
||
|
||
if (typeof enabled !== 'boolean') {
|
||
throw new ValidationError('enabled must be a boolean');
|
||
}
|
||
|
||
if (intervalMs !== undefined) {
|
||
if (!Number.isInteger(intervalMs) || intervalMs < 10000 || intervalMs > 86400000) {
|
||
throw new ValidationError('intervalMs must be an integer between 10000 and 86400000 (10s – 24h)');
|
||
}
|
||
}
|
||
|
||
if (enabled) {
|
||
driftDetector.startPolling(intervalMs || 300000);
|
||
success(res, {
|
||
message: 'Drift polling enabled',
|
||
intervalMs: intervalMs || 300000,
|
||
});
|
||
} else {
|
||
driftDetector.stopPolling();
|
||
success(res, { message: 'Drift polling disabled' });
|
||
}
|
||
}, 'drift-polling'));
|
||
|
||
return router;
|
||
};
|