sami7777/dashcaddy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: hide broken service logo images gracefully in edit modal
CI / Test & Lint (push) Canceled after 0s
Details
CI / Security audit (push) Canceled after 0s
Details

Browse Source 
Adds onerror handler to edit-service-logo-preview that hides the img
when the logo source fails to load, preventing broken-image icons.
This commit is contained in:
Hermes
2026-08-13 14:38:22 -07:00
parent 7203130b02
commit 2ada4694a2
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
status/dist/core.js
Vendored
+2 -2
View File
File diff suppressed because one or more lines are too long
status/js/core/service-crud.js
+7 -1
View File
@@ -12,7 +12,13 @@
document.getElementById('service-edit-title').textContent = `Edit ${service.name}`;
document.getElementById('edit-service-name').value = service.name;
document.getElementById('edit-service-url-display').textContent = service.url || buildServiceUrl(service.id);
document.getElementById('edit-service-logo-preview').src = service.logo || `/assets/${service.id}.png`;
const logoPreview = document.getElementById('edit-service-logo-preview');
const logoSrc = service.logo || `/assets/${service.id}.png`;
logoPreview.src = logoSrc;
// Hide broken images gracefully instead of showing a broken icon
logoPreview.onerror = function() { this.style.display = 'none'; };
logoPreview.onload = function() { this.style.display = ''; };
logoPreview.style.display = '';
document.getElementById('edit-subdomain').value = service.id;
document.getElementById('edit-port').value = service.port || '';
document.getElementById('edit-ip').value = service.ip || 'localhost';