4 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Hermes	2d394d882d	Standardize response shapes and fix dead fetchT timeout keys ... Three small cleanups for v1.14.0: 1. /caddy/cas now uses standard success envelope Was: { status: 'success', data: { cas: caList } } Now: { success: true, cas: caList } Updated frontend service-infrastructure.js to match. 2. /api/health/ca now uses standard envelope + meaningful HTTP codes Was: { status, message, daysUntilExpiration } with 200 on every error Now: { success, caStatus, message|error, daysUntilExpiration } with 200 / 404 / 500 as appropriate caStatus field preserves the original 'healthy'/'warning'/'critical'/'error' semantic so any future consumer of the CA-health state still has it. Tests updated to match. 3. Dead timeout: keys in fetchT opts are now a warning, not a silent strip src/utils/http.js:41 used to do without telling anyone. Callers that wrote fetchT(url, { timeout: 5000 }) got the default 5s timeout with no indication that their explicit value was ignored. Now it logs a warning naming the call site, then strips the key. Fixed 4 call sites that had stale timeout: keys: - src/context/caddy.js - src/context/dns.js - src/context/provider-dns.js - routes/dns.js (2 places)	2026-06-10 21:52:33 -07:00
Hermes	11cfb8c26a	Consolidate response helpers and error logger to single modules ... Two cleanups in one pass for the v1.14.0 'works on any platform' theme: 1. Response helpers — merged src/utils/responses.js and the root-level response-helpers.js into a single module at src/utils/responses.js. The old module had a richer set (created, noContent, validationError, unauthorized, forbidden, notFound, conflict) and is now re-exported from the new location. Updated 15 routes to import from src/utils/responses and deleted the root response-helpers.js. 2. Error logger — error-handler.js now uses the unified src/utils/logging.js#logError (same one src/app.js uses), so all errors go to one log file with one rotation policy. Removed the dead asyncHandler export (the real one is in src/utils/async-handler.js and is used everywhere). Deleted the legacy error-logger.js. Both are invisible to users — same HTTP response shapes, same log file path, same error format. Internal-only refactor.	2026-06-10 21:37:55 -07:00
Hermes	caa09dcebe	Bump to v1.13.1 - fix /health/ready res.status bug ... The readiness probe was using asyncHandler directly, but this codebase's asyncHandler has signature (logError, fn, context) — first arg is the logger. Switched to boundAsyncHandler which is what every other route in src/app.js uses. Verified working on both DNS2 (Docker) and Contabo (systemd). 8 new tests in __tests__/health-endpoints.test.js verify both endpoints.	2026-06-10 21:12:37 -07:00
Hermes	264de9644c	Fix /health/ready res.status bug + add comprehensive health endpoint tests ... The readiness probe was crashing with 'res.status is not a function' because asyncHandler(async (req, res) => {...}, 'health-ready') was called directly, but asyncHandler's signature is (logError, fn, context) — first arg is the logger, not the handler. The fix uses boundAsyncHandler like all other routes in the file do. Added 8 unit tests for both /health/live and /health/ready: - live always 200 (liveness ≠ readiness) - ready returns 503 when config/services/docker fail - no 'res.status is not a function' crash when dependencies fail - all 4 check keys present in response Also added MONITORING_PUBLIC env var (defaults true) and the new health endpoints to PUBLIC_ROUTES so k8s probes can hit them without auth.	2026-06-10 20:35:27 -07:00