[grade=B urn:ump:x37xj4seku3isvffxkwmahymvjijrwinndnfpubv664spur7kogq] fix(installer): remove BACKUP_DIR readonly collision that aborted every install

readonly BACKUP_DIR (constants) collided with the BACKUP_DIR= tunable, so every
curl|bash run died with 'BACKUP_DIR: readonly variable'. Removed the readonly
constant and resolve the default (/etc/dashcaddy/backups) at end of parse_args;
--backup-dir flag still overrides. Live file + /opt copy patched identically.

dashcaddy-api/__tests__/network-people-store.test.js

@@ -82,6 +82,26 @@ describe('network-people-store: CRUD', () => {
     expect(list).toHaveLength(1); // merged, not duplicated
   });
 
+  test('upsertPerson merges by providerUserId when id is omitted (wizard after provider sync)', async () => {
+    const synced = await store.upsertPerson({
+      displayName: 'SamiAhmed7777',
+      providerUserId: 'ughVnuLDu621CNTRL',
+    });
+    expect(synced.groups).toEqual(['Admin']); // bootstrap identity
+
+    const fromWizard = await store.upsertPerson({
+      displayName: 'Sami Ahmed',
+      providerUserId: 'ughVnuLDu621CNTRL',
+    });
+
+    expect(fromWizard.id).toBe(synced.id);
+    expect(fromWizard.displayName).toBe('Sami Ahmed');
+    expect(fromWizard.groups).toEqual(['Admin']);
+    expect(fromWizard.protectedAt).toBe(synced.protectedAt);
+    const list = await store.listPeople();
+    expect(list).toHaveLength(1);
+  });
+
   test('updatePerson patches only provided fields', async () => {
     const p = await store.upsertPerson({ displayName: 'Bob', providerUserId: 'ts-2', groups: ['G'] });
     const u = await store.updatePerson(p.id, { displayName: 'Bobby' });

dashcaddy-api/src/security/network-people-store.js

@@ -180,7 +180,17 @@ function createPeopleStore(opts = {}) {
   function upsertPerson(input = {}) {
     return _enqueue(() => {
       const data = _load();
-      const existing = input.id ? data.people[input.id] : null;
+      // Resolve the existing record by id when given, else by providerUserId
+      // (dogfood finding 2026-10-04: the wizard upserts a person AFTER a
+      // provider sync already created one for the same Tailscale user with no
+      // id — without this lookup the same providerUserId was duplicated).
+      const existing = input.id
+        ? data.people[input.id]
+        : (input.providerUserId
+            ? Object.values(data.people).find(
+                (p) => p.providerUserId && p.providerUserId === input.providerUserId
+              ) || null
+            : null);
       const isFirst = Object.keys(data.people).length === 0;
 
       const id = existing ? existing.id : (input.id || crypto.randomUUID());

dashcaddy-installer/install.sh

@@ -27,7 +27,6 @@ readonly API_DIR="${SITES_DIR}/dashcaddy-api"
 readonly DASHBOARD_DIR="${SITES_DIR}/status"
 readonly CONTAINER_NAME="dashcaddy-api"
 readonly CADDY_ADMIN_PORT=2019
-readonly BACKUP_DIR="${BACKUP_DIR:-${INSTALL_DIR}/backups}"
 readonly DEFAULT_MAX_STORAGE_BYTES=""
 
 # ---- Tunables (overridable via flags) --------------------------------------
@@ -1045,6 +1044,9 @@ parse_args() {
 
   # Normalize TLD
   if [[ -n "$TLD" && "$TLD" != .* ]]; then TLD=".$TLD"; fi
+
+  # Resolve BACKUP_DIR default when not set by the --backup-dir flag.
+  BACKUP_DIR="${BACKUP_DIR:-${INSTALL_DIR}/backups}"
 }
 
 print_help() {