[grade=B urn:ump:x37xj4seku3isvffxkwmahymvjijrwinndnfpubv664spur7kogq] fix(installer): remove BACKUP_DIR readonly collision that aborted every install

readonly BACKUP_DIR (constants) collided with the BACKUP_DIR= tunable, so every curl|bash run died with 'BACKUP_DIR: readonly variable'. Removed the readonly constant and resolve the default (/etc/dashcaddy/backups) at end of parse_args; --backup-dir flag still overrides. Live file + /opt copy patched identically.
P7 people-store providerUserId dedupe [grade=B] (PR #4 )
2026-10-05 18:18:22 -07:00 · 2026-10-04 12:14:44 +02:00
1 changed files with 3 additions and 1 deletions
@@ -27,7 +27,6 @@ readonly API_DIR="${SITES_DIR}/dashcaddy-api"
 readonly DASHBOARD_DIR="${SITES_DIR}/status"
 readonly CONTAINER_NAME="dashcaddy-api"
 readonly CADDY_ADMIN_PORT=2019
-readonly BACKUP_DIR="${BACKUP_DIR:-${INSTALL_DIR}/backups}"
 readonly DEFAULT_MAX_STORAGE_BYTES=""

 # ---- Tunables (overridable via flags) --------------------------------------
@@ -1045,6 +1044,9 @@ parse_args() {

  # Normalize TLD
  if [[ -n "$TLD" && "$TLD" != .* ]]; then TLD=".$TLD"; fi
+
+  # Resolve BACKUP_DIR default when not set by the --backup-dir flag.
+  BACKUP_DIR="${BACKUP_DIR:-${INSTALL_DIR}/backups}"
 }

 print_help() {
Author	SHA1	Message	Date
Hermes	1fa5ba8baa	[grade=B urn:ump:x37xj4seku3isvffxkwmahymvjijrwinndnfpubv664spur7kogq] fix(installer): remove BACKUP_DIR readonly collision that aborted every install CI / Test & Lint (push) Canceled after 0s Details CI / Security audit (push) Canceled after 0s Details readonly BACKUP_DIR (constants) collided with the BACKUP_DIR= tunable, so every curl\|bash run died with 'BACKUP_DIR: readonly variable'. Removed the readonly constant and resolve the default (/etc/dashcaddy/backups) at end of parse_args; --backup-dir flag still overrides. Live file + /opt copy patched identically.	2026-10-05 18:18:22 -07:00
sami7777	0fd1bbd80b	P7 people-store providerUserId dedupe [grade=B] (PR #4 ) CI / Test & Lint (push) Canceled after 0s Details CI / Security audit (push) Canceled after 0s Details Judge B r1 urn:ump:bbfbsfru4nizg75wcxum7mwzhie6txhr22hw6jvz36wiihmgzmlq. Dogfood finding #3. 3414/3414.	2026-10-04 12:14:44 +02:00